Skip to content

Turn off ASAN leak detection running tscore/CompileParseRules during build#13137

Merged
cmcfarlen merged 1 commit into
apache:masterfrom
cmcfarlen:fix-asan-leak-rules-parser
May 11, 2026
Merged

Turn off ASAN leak detection running tscore/CompileParseRules during build#13137
cmcfarlen merged 1 commit into
apache:masterfrom
cmcfarlen:fix-asan-leak-rules-parser

Conversation

@cmcfarlen

Copy link
Copy Markdown
Contributor

No description provided.

@cmcfarlen cmcfarlen added this to the 11.0.0 milestone May 5, 2026
@cmcfarlen cmcfarlen self-assigned this May 5, 2026
@cmcfarlen cmcfarlen added the Build work related to build configuration or environment label May 5, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor Author

[approve ci osx autest 0]

@bryancall bryancall requested a review from Copilot May 11, 2026 22:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the build-time generation of tscore parse rules so that running the CompileParseRules helper does not trigger AddressSanitizer leak checking, avoiding leak-report-based failures during the build.

Changes:

  • Wrap the CompileParseRules custom command invocation with cmake -E env to set ASAN_OPTIONS=detect_leaks=0.
  • Invoke the generator via $<TARGET_FILE:CompileParseRules> (explicit target path).

Comment thread src/tscore/CMakeLists.txt
@cmcfarlen cmcfarlen merged commit 4bba678 into apache:master May 11, 2026
19 checks passed
@cmcfarlen cmcfarlen deleted the fix-asan-leak-rules-parser branch May 11, 2026 22:36
@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x May 11, 2026
@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x May 14, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 May 14, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor Author

Cherry-picked to 10.2.x

cmcfarlen added a commit that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment

Projects

Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

3 participants